# \#code-review

**URL:** https://swi-prolog.discourse.group/tag/code-review/54.md

[Latest](https://swi-prolog.discourse.group/latest.md) · [Categories](https://swi-prolog.discourse.group/categories.md) · [Tags](https://swi-prolog.discourse.group/tags.md)

---

## [Can those who know EDCG check that this was done correctly](https://swi-prolog.discourse.group/t/can-those-who-know-edcg-check-that-this-was-done-correctly/2015)

<div class="topic-metadata">

**Author:** [@EricGT](https://swi-prolog.discourse.group/u/EricGT)\
**Replies:** 4\
**Last updated:** [March 16, 2020, 7:25am UTC](https://swi-prolog.discourse.group/t/can-those-who-know-edcg-check-that-this-was-done-correctly/2015 "2020-03-16T07:25:14Z")

</div>

Using SWI-Prolog (threaded, 64 bits, version 8.1.24) on Windows. Being new to using EDCGs just want to make sure I am doing this correctly. The key piece of the code that I am not sure is the correct way to do it with E…